[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing sn
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close. |
|
Date: |
Fri, 14 Feb 2014 11:01:35 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 13.02.2014 um 17:22 hat Benoît Canet geschrieben:
> As bdrv_open() documentation states:
> "The reference to the QDict belongs to the block layer
> * after the call (even on failure), so if the caller intends to reuse the
> * dictionary, it needs to use QINCREF() before calling bdrv_open."
>
> the optional options dict will not be reused after bdrv_open() and should
> belong to the block layer so remove the extra QDECREF(options).
>
> Signed-off-by: Benoit Canet <address@hidden>
Ouch, yes. Sorry for not catching this in the review.
Reviewed-by: Kevin Wolf <address@hidden>