Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

[Andreas Färber]

Hi,

Am 14.02.2014 10:38, schrieb Greg Kurz:
> On Thu, 17 Oct 2013 14:23:35 +1030
> Rusty Russell <address@hidden> wrote:
>> This is a re-transmit of the core of the virtio endian code.  Since
>> there seems to be some interest in ARM BE virtio, I've separated this from
>> the direct problem I was solving: PowerPC LE.
>>
>> Please apply!
>> Rusty.
>>
> 
> Hi,
> 
> This serie is needed to enable current legacy virtio devices in a
> cross-endian environment. Even though virtio-1.0 will address endianess
> questions at the specification level, it is still in its early boot phase
> and no code will be available before long (Rusty, please correct me if I am
> wrong).
> 
> We have all the PPC KVM bits in 3.14 already. We have PPC QEMU patches
> ready to be applied by Alexander, as soon as the common code gets in.
> Anthony has already positively reviewed this serie. We have been testing
> for some monthes... Now we are waiting for partners ! :)
> 
> Are the ARM people still interested in cross-endian virtio ? Are there
> other people interested (Thomas for s390) ?
> 
> If so, please participate or we will have to wait for the new standard to be
> finalized and implemented... :-\

It might've helped if Rusty had actually used our
scripts/get_maintainer.pl script to CC people. While Anthony seems to
have reviewed some patches (usually Reviewed-by should be before the
final Signed-off-by fwiw), neither Stefan (virtio-net) nor Kevin
(virtio-blk) nor Paolo (virtio-scsi) were CC'ed, and recently Michael
stepped up as virtio maintainer, so maybe he can take them once ready.

1/7 looks okay to me; 3-7 are rather mechanical - people will need to
review that those changes are sufficient for the current code base.
We've since converted virtio devices to QOM realize, so a rebase is
likely needed for such an "old" series.

Regards,
Andreas

>> Rusty Russell (7):
>>   virtio_get_byteswap: function for endian-ambivalent targets using
>>     virtio.
>>   virtio: allow byte swapping for vring and config access
>>   hw/net/virtio-net: use virtio wrappers to access headers.
>>   hw/net/virtio-balloon: use virtio wrappers to access page frame
>>     numbers.
>>   hw/block/virtio-blk: use virtio wrappers to access headers.
>>   hw/scsi/virtio-scsi: use virtio wrappers to access headers.
>>   hw/char/virtio-serial-bus: use virtio wrappers to access headers.
>>
>>  hw/block/virtio-blk.c             |  35 +++++-----
>>  hw/char/virtio-serial-bus.c       |  34 +++++-----
>>  hw/net/virtio-net.c               |  15 +++--
>>  hw/scsi/virtio-scsi.c             |  33 +++++-----
>>  hw/virtio/virtio-balloon.c        |   3 +-
>>  hw/virtio/virtio.c                |  34 ++++++----
>>  include/hw/virtio/virtio-access.h | 133
>> ++++++++++++++++++++++++++++++++++++++ include/hw/virtio/virtio.h
>> |   2 + stubs/Makefile.objs               |   1 +
>>  stubs/virtio_get_byteswap.c       |   6 ++
>>  10 files changed, 225 insertions(+), 71 deletions(-)
>>  create mode 100644 include/hw/virtio/virtio-access.h
>>  create mode 100644 stubs/virtio_get_byteswap.c

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg