Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

[Alexander Graf]

On 14.02.2014, at 14:54, Alexander Graf <address@hidden> wrote:

> 
> On 14.02.2014, at 14:06, Alexander Graf <address@hidden> wrote:
> 
>> 
>> On 13.02.2014, at 15:51, Alexander Graf <address@hidden> wrote:
>> 
>>> 
>>> On 13.02.2014, at 11:40, Greg Kurz <address@hidden> wrote:
>>> 
>>>> On Thu, 13 Feb 2014 08:29:28 +0530
>>>> "Aneesh Kumar K.V" <address@hidden> wrote:
>>>> 
>>>>> From: "Aneesh Kumar K.V" <address@hidden>
>>>>> 
>>>>> Correctly update the htab_mask using the return value of
>>>>> KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1
>>>>> on GET_SREGS for HV. We check for external htab and if
>>>>> found true, we don't need to update sdr1
>>>>> 
>>>>> Signed-off-by: Aneesh Kumar K.V <address@hidden>
>>>> 
>>>> Reviewed-by: Greg Kurz <address@hidden>
>>>> 
>>>>> ---
>>>>> Changes from V9:
>>>>> * Fix TCG breakage
>>>>> 
>>>> 
>>>> Alex,
>>>> 
>>>> This patch is a complete replacement for commit 1df2d6d900a9 in your
>>>> ppc-next branch.
>>>> 
>>>> Please apply so that TCG works again ! :)
>>> 
>>> Thanks, applied to ppc-next.
>> 
>> With this patch applied -M pseries fails to boot a kernel for me.
> 
> -M mac99 also fails miserably. It almost looks as if the mask cuts off some 
> bits, but please investigate this yourself. I'll remove the patch from the 
> queue meanwhile.

Sigh, this whole series is just way too broken. I'll remove everything as of 
this patch from my queue. Aneesh, please rework the HTAB load/store patches and 
make sure that

  - TCG works
  - -M mac99 works
  - 32bit guest works
  - 32bit host works (casts!)

Then we can talk about applying them again.


Alex