[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/20] curl: correctly propagate errors
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v3 10/20] curl: correctly propagate errors |
Date: |
Mon, 17 Feb 2014 14:43:57 +0100 |
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/curl.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index a807584..7edb3cc 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -456,30 +456,27 @@ static int curl_open(BlockDriverState *bs, QDict
*options, int flags,
static int inited = 0;
if (flags & BDRV_O_RDWR) {
- qerror_report(ERROR_CLASS_GENERIC_ERROR,
- "curl block device does not support writes");
+ error_setg(errp, "curl block device does not support writes");
return -EROFS;
}
opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
qemu_opts_absorb_qdict(opts, options, &local_err);
if (error_is_set(&local_err)) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_propagate(errp, local_err);
goto out_noclean;
}
s->readahead_size = qemu_opt_get_size(opts, "readahead", READ_AHEAD_SIZE);
if ((s->readahead_size & 0x1ff) != 0) {
- fprintf(stderr, "HTTP_READAHEAD_SIZE %zd is not a multiple of 512\n",
- s->readahead_size);
+ error_setg(errp, "HTTP_READAHEAD_SIZE %zd is not a multiple of 512",
+ s->readahead_size);
goto out_noclean;
}
file = qemu_opt_get(opts, "url");
if (file == NULL) {
- qerror_report(ERROR_CLASS_GENERIC_ERROR, "curl block driver requires "
- "an 'url' option");
+ error_setg(errp, "curl block driver requires an 'url' option");
goto out_noclean;
}
--
1.8.5.3
- [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 01/20] nbd: produce a better error if neither host nor port is passed, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 02/20] nbd: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 03/20] nbd: inline tcp_socket_incoming_spec into sole caller, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 04/20] nbd: move socket wrappers to qemu-nbd, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 05/20] iscsi: fix indentation, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 07/20] gluster: default scheme to gluster:// and host to localhost., Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 09/20] cow: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 08/20] gluster: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 10/20] curl: correctly propagate errors,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v3 11/20] qcow: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 15/20] vmdk: extract vmdk_read_desc, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 19/20] block: do not abuse EMEDIUMTYPE, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 12/20] qed: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 13/20] vhdx: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 14/20] vvfat: correctly propagate errors, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 16/20] vmdk: push vmdk_read_desc up to caller, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 17/20] vmdk: do not try opening a file as both image and descriptor, Paolo Bonzini, 2014/02/17
- [Qemu-devel] [PATCH v3 18/20] vmdk: correctly propagate errors, Paolo Bonzini, 2014/02/17