Re: [Qemu-devel] Hotplug vs. multifunction regression

[Michael S. Tsirkin]

On Mon, Feb 17, 2014 at 07:10:51AM -0700, Alex Williamson wrote:
> [cc +igor, +mst]
> 
> Appears that it's no longer possible to use multifunction devices at
> PCIe at all due to hotplug being an integral part of device realization
> now.  Thanks,
> 
> Alex

Yes, Igor just fixed it.

> On Sun, 2014-02-16 at 15:57 +0000, Nigel Kukard wrote:
> > Hi guys,
> > 
> > Starting from the patch series in 9f117d41 the below error is
> > observed... (reverting to the patch right before it works fine a1483f88)
> > 
> > Here is the error:
> > qemu-system-x86_64: hw/pci/pcie.c:240: pcie_cap_slot_hotplug_common:
> > Assertion `((pci_dev->devfn) & 0x07) == 0' failed.
> > 
> > Here is the command that generated it...
> > 
> > CMDLINE: $VAR1 = [
> >           'qemu-system-x86_64',
> >           '-m',
> >           '8G',
> >           '-machine',
> >           'q35',
> >           '-cpu',
> >           'qemu64',
> >           '-smp',
> >           '4,sockets=1,cores=4,threads=1',
> >           '-enable-kvm',
> >           '-device',
> >          
> > 'ioh3420,bus=pcie.0,addr=1c.0,multifunction=on,port=1,chassis=1,id=root.1',
> >           '-device',
> >          
> > 'vfio-pci,host=03:00.0,bus=root.1,addr=0.0,multifunction=on,x-vga=on',
> >           '-device',
> >           'vfio-pci,host=03:00.1,bus=root.1,addr=0.1',
> >           '-device',
> >           'ide-drive,drive=sata-disk0,bus=ide.0',
> >           '-drive',
> >          
> > 'file=510-drive_sda.qcow2,id=sata-disk0,format=qcow2,cache=writeback,if=none',
> >           '-vga',
> >           'none',
> >           '-nographic',
> >           '-boot',
> >           'menu=on',
> >         ];
> > 
> > It seems the hotplug interface doesn't know how to handle multifunction
> > devices.
> > 
> > -N
> > 
> 
>