qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/6] NUMA: convert -numa option to use OptsVisit


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor
Date: Mon, 17 Feb 2014 09:36:11 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 02/17/2014 08:49 AM, Igor Mammedov wrote:
> From: Wanlong Gao <address@hidden>
> 
> Signed-off-by: Wanlong Gao <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4420,3 +4420,35 @@

> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node. (for OptsVisitor)
> +#
> +# @nodeid: #optional NUMA node ID (increase by 1 from 0 if omitted)
> +#
> +# @cpus: #optional VCPUs belong to this node (assign VCPUS round-robin

s/belong/belonging/

> +#         if omitted)
> +#
> +# @mem: #optional memory size of this node (go halves total memory to
> +#        each node if omitted)

Awkward grammar.  I suggest:

#optional memory size of this node (equally divide total memory among
nodes if omitted)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]