[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIR
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated |
Date: |
Mon, 17 Feb 2014 09:52:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/16/2014 07:27 PM, Amos Kong wrote:
> Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't
> filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated.
>
> We should also not send the vlan table to management, this patch makes
> the vlan-talbe optional.
s/talbe/table/
>
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg02604.html
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> hw/net/virtio-net.c | 38 +++++++++++++++++++++++++-------------
> qapi-schema.json | 4 ++--
> qmp-commands.hx | 2 +-
> 3 files changed, 28 insertions(+), 16 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -4034,7 +4034,7 @@
> #
> # @main-mac: the main macaddr string
> #
> -# @vlan-table: a list of active vlan id
> +# @vlan-table: #optional a list of active vlan id
> #
> # @unicast-table: a list of unicast macaddr string
> #
> @@ -4053,7 +4053,7 @@
> 'multicast-overflow': 'bool',
> 'unicast-overflow': 'bool',
> 'main-mac': 'str',
> - 'vlan-table': ['int'],
> + '*vlan-table': ['int'],
Indentation is now off.
> - "main-mac": main macaddr string (json-string)
> -- "vlan-table": a json-array of active vlan id
> +- "vlan-table": a json-array of active vlan id (optoinal)
s/optoinal/optional/
Those fixes are trivial enough, so I'm okay if you correct them then add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature