Re: [Qemu-devel] [PATCH 0/6] A64: finish Neon 3-reg-diff category, add LDTR/STTR

[Richard Henderson]

On 02/16/2014 12:21 PM, Peter Maydell wrote:
> Another patchset of random filling in the gaps in our Neon
> coverage. Patches 1 through 5 complete our handling of the
> three-reg-different category of Neon instructions.
> 
> Patch 6 implements the "unprivileged load/store" LDTR/STTR
> instructions. (In fact AArch64 Linux doesn't use these, and they're
> pretty pointless in user mode, but they're easy enough to implement.)
> 
> I haven't put in any of the fp_access_check() calls because
> I'm assuming these will pass code review before the system
> emulation patchset does; I'll update the latter to add the
> extra checks as necessary at that point.
> 
> thanks
> -- PMM

Aside from a nit in 5/6,

Reviewed-by: Richard Henderson <address@hidden>


r~