Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

[Andreas Färber]

Am 17.02.2014 19:59, schrieb Paolo Bonzini:
> Il 17/02/2014 15:37, Peter Maydell ha scritto:
>> Three random easy patches fixing issues reported by Coverity Scan.
>>
>> Peter Maydell (3):
>>   hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses
>>   hw/net/stellaris_enet: Avoid unintended sign extension
>>   hw/timer/arm_timer: Avoid array overrun for bad addresses
>>
>>  hw/misc/arm_sysctl.c    | 4 ++--
>>  hw/net/stellaris_enet.c | 3 ++-
>>  hw/timer/arm_timer.c    | 2 ++
>>  3 files changed, 6 insertions(+), 3 deletions(-)
>>
> 
> Reviewed-by: Paolo Bonzini <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

The reindent in 2/3 wouldn't have been strictly necessary, it seemed
space-aligned to after return, but it's not wrong either.

Shouldn't 1/3 and 3/3 be included in 1.7.1 as guest-triggerable bugs?
There's no address@hidden in the commit message.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg