Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages

[Fam Zheng]

On Mon, 02/17 14:43, Paolo Bonzini wrote:
> Most of the block drivers are not using the Error** argument to bdrv_open,
> and instead just printing errors to stderr.  This series improves that,
> and as a consequence it also avoids abuse of errno numbers.
> 
> The only hurdle (caught by qemu-iotests, too) is VMDK, where we currently
> parse a file first as image, and second as a descriptor.  This makes
> it hard to pick a good error message, because you do not know which
> attempt gave the most reasonable error message.  For this reason patches
> 15-17 modify this approach and push up the detection of vmdk image file
> magic numbers.
> 
> Apart from this, and from a segfault fixed by patch 7, the series consists
> of mostly trivial patches.
> 
> Paolo
> 
>         v2->v3:
>                 Rebase for new qemu-nbd test (Jeff, 01-02/20)
>                 Fix memory leak (Stefan, 06/20)
>                 Use local_err for bdrv_file_open (Kevin, 09-11-12/20)
> 

Did an incremental review from v1 where I already left reviewed-by's for most
patches, and this revision looks good to me. The only minor comment is on v19
about error message text (I replied in v2 series), but it needn't stop merging.
Thanks, the series:

Reviewed-by: Fam Zheng <address@hidden>