Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage

[Dr. David Alan Gilbert]

* address@hidden (address@hidden) wrote:
> From: "Michael R. Hines" <address@hidden>
> 
> We also later export these statistics over QMP for better
> monitoring of micro-checkpointing as the workload changes.

<snip>

> @@ -548,9 +568,11 @@ static int ram_save_block(QEMUFile *f, bool last_stage)
>              /* XBZRLE overflow or normal page */
>              if (bytes_sent == -1) {
>                  bytes_sent = save_block_hdr(f, block, offset, cont, 
> RAM_SAVE_FLAG_PAGE);
> -                qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE);
> -                bytes_sent += TARGET_PAGE_SIZE;
> -                acct_info.norm_pages++;
> +                if (ret != RAM_SAVE_CONTROL_DELAYED) {
> +                    qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE);
> +                    bytes_sent += TARGET_PAGE_SIZE;
> +                    acct_info.norm_pages++;
> +                }
>              }

Is that last change intended for this patch; it doesn't look
timestamp related.

Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK