[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v18 02/14] NUMA: check if the total numa memory size
From: |
Hu Tao |
Subject: |
[Qemu-devel] [PATCH v18 02/14] NUMA: check if the total numa memory size is equal to ram_size |
Date: |
Wed, 19 Feb 2014 15:53:53 +0800 |
From: Wanlong Gao <address@hidden>
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table
and recognize all memory to one node. It's buggy, we should
check it to ensure that we write the right data to ACPI table.
Signed-off-by: Wanlong Gao <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Hu Tao <address@hidden>
---
numa.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/numa.c b/numa.c
index 7845036..a06e2d1 100644
--- a/numa.c
+++ b/numa.c
@@ -151,6 +151,16 @@ void set_numa_nodes(void)
node_mem[i] = ram_size - usedmem;
}
+ uint64_t numa_total = 0;
+ for (i = 0; i < nb_numa_nodes; i++) {
+ numa_total += node_mem[i];
+ }
+ if (numa_total != ram_size) {
+ fprintf(stderr, "qemu: numa nodes total memory size "
+ "should equal to ram_size\n");
+ exit(1);
+ }
+
for (i = 0; i < nb_numa_nodes; i++) {
if (!bitmap_empty(node_cpumask[i], MAX_CPUMASK_BITS)) {
break;
--
1.8.5.2.229.g4448466
- [Qemu-devel] [PATCH v18 04/14] NUMA: convert -numa option to use OptsVisitor, (continued)
- [Qemu-devel] [PATCH v18 04/14] NUMA: convert -numa option to use OptsVisitor, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 07/14] add memdev backend infrastructure, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 09/14] numa: introduce memory_region_allocate_system_memory, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 08/14] pc: pass QEMUMachineInitArgs to pc_memory_init, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 02/14] NUMA: check if the total numa memory size is equal to ram_size,
Hu Tao <=
- [Qemu-devel] [PATCH v18 14/14] amp: add query-memdev, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 05/14] NUMA: expand MAX_NODES from 64 to 128, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields, Hu Tao, 2014/02/19