[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor |
Date: |
Wed, 19 Feb 2014 10:54:28 +0100 |
On Wed, 19 Feb 2014 15:53:57 +0800
Hu Tao <address@hidden> wrote:
> From: Igor Mammedov <address@hidden>
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Hu Tao <address@hidden>
replace it with a better patch from Paolo that soon
will get merged into master:
http://www.mail-archive.com/address@hidden/msg216512.html
> ---
> qapi/string-input-visitor.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
> index 8f1bc41..a152f5d 100644
> --- a/qapi/string-input-visitor.c
> +++ b/qapi/string-input-visitor.c
> @@ -97,6 +97,23 @@ static void parse_type_number(Visitor *v, double *obj,
> const char *name,
> *obj = val;
> }
>
> +static void parse_type_size(Visitor *v, uint64_t *obj, const char *name,
> + Error **errp)
> +{
> + StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
> + int64_t val;
> + char *endp;
> +
> + val = strtosz_suffix(siv->string ? siv->string : "", &endp,
> + STRTOSZ_DEFSUFFIX_B);
> + if (val < 0 || *endp != '\0') {
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE, name,
> + "a size value representible as a non-negative int64");
> + return;
> + }
> + *obj = val;
> +}
> +
> static void parse_start_optional(Visitor *v, bool *present,
> const char *name, Error **errp)
> {
> @@ -131,6 +148,7 @@ StringInputVisitor *string_input_visitor_new(const char
> *str)
> v->visitor.type_bool = parse_type_bool;
> v->visitor.type_str = parse_type_str;
> v->visitor.type_number = parse_type_number;
> + v->visitor.type_size = parse_type_size;
> v->visitor.start_optional = parse_start_optional;
>
> v->string = str;
- [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list, (continued)
- [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 03/14] NUMA: Add numa_info structure to contain numa nodes info, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 04/14] NUMA: convert -numa option to use OptsVisitor, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 07/14] add memdev backend infrastructure, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor, Hu Tao, 2014/02/19
- Re: [Qemu-devel] [PATCH v18 06/14] qapi: add SIZE type parser to string_input_visitor,
Igor Mammedov <=
- [Qemu-devel] [PATCH v18 09/14] numa: introduce memory_region_allocate_system_memory, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 10/14] numa: add -numa node, memdev= option, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 08/14] pc: pass QEMUMachineInitArgs to pc_memory_init, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 02/14] NUMA: check if the total numa memory size is equal to ram_size, Hu Tao, 2014/02/19
- [Qemu-devel] [PATCH v18 14/14] amp: add query-memdev, Hu Tao, 2014/02/19