Re: [Qemu-devel] [PATCH 4/5] tcg/i386: Use ANDN instruction

[Peter Maydell]

On 20 February 2014 16:25, Peter Maydell <address@hidden> wrote:
> On 31 January 2014 14:43, Richard Henderson <address@hidden> wrote:
>> Note that the optimizer cannot simplify ANDC X,Y,C to AND X,Y,~C
>> so we must handle constants in the implementation of andc.
>
> Unfortunately I failed to notice before I applied this,
> but this breaks the build for w32:
>
>   LINK  aarch64-softmmu/qemu-system-aarch64.exe
> tcg/tcg.o: In function `tcg_target_init':
> /home/petmay01/linaro/qemu-for-merges/tcg/i386/tcg-target.c:2263:
> undefined reference to `___get_cpuid_max'
> /home/petmay01/linaro/qemu-for-merges/tcg/i386/tcg-target.c:2266:
> undefined reference to `___cpuid'
> /home/petmay01/linaro/qemu-for-merges/tcg/i386/tcg-target.c:2282:
> undefined reference to `___cpuid_count'
> collect2: ld returned 1 exit status
>
>
> Can you provide a reasonably quick fix, or should I
> just revert commits 9d2eec20 and 6399ab33 for the moment?

Breaks clang builds too (on MacOSX and otherwise).

-- PMM