[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tcg/i386: Fix build for systems without work
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) |
|
Date: |
Thu, 20 Feb 2014 15:08:22 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/20/2014 01:42 PM, Peter Maydell wrote:
> Win32 doesn't have a cpuid.h, and MacOSX may have one but without
> the __cpuid() function we use, which means that commit 9d2eec20
> broke the build for those platforms. Fix this by tightening up
> our configure cpuid.h check to test that the functions we need
> are present, and adding some missing #ifdef guards in
> tcg/i386/tcg-target.c.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Changes v1->v2: fix typo in commit message, add __cpuid_count()
> to the configure test
>
> configure | 13 ++++++++++++-
> tcg/i386/tcg-target.c | 4 +++-
> 2 files changed, 15 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~