Re: [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for qdict_array_split()

[Max Reitz]

On 21.02.2014 19:39, Eric Blake wrote:
> On 02/21/2014 11:11 AM, Max Reitz wrote:
> > Test the new functionality of qdict_array_split(), that is, splitting
> > off single objects.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >   tests/check-qdict.c | 22 ++++++++++++++++------
> >   1 file changed, 16 insertions(+), 6 deletions(-)
> Reviewed-by: Eric Blake <address@hidden>
>
> However, I think it is incomplete - you didn't test the behavior when
> both %u and %u.sub appear in the same dict, to make sure the splitting
> stops at that point.

Yes, I'll add a test for that case, too.


Thanks for you review,

Max