[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] check-qdict: Test termination of qdict_array
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] check-qdict: Test termination of qdict_array_split() |
Date: |
Fri, 21 Feb 2014 13:34:17 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 01:05 PM, Max Reitz wrote:
> qdict_array_split() should terminate if it encounters both an entry with
> a key of "%u" and entries with keys prefixed "%u." for the same index.
>
> This patch adds a test for this case.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> This is a followup to my "Extract non-QDicts in qdict_array_split()" series.
>
> + /*
> + * Test the split of
> + *
> + * {
> + * "0": 42,
> + * "1": 23,
> + * "1.x": 84
> + * }
For good measure, I might have included a "2":..., which also does not
get split out (proving that we didn't just skip over 1 and go on to 2,
but actually stopped). But at this point, I think you've covered the
code, so I won't insist.
Thanks for the extra test:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature