qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] check-qdict: Test termination of qdict_array


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2] check-qdict: Test termination of qdict_array_split()
Date: Fri, 21 Feb 2014 22:18:53 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 21.02.2014 um 21:34 hat Eric Blake geschrieben:
> On 02/21/2014 01:05 PM, Max Reitz wrote:
> > qdict_array_split() should terminate if it encounters both an entry with
> > a key of "%u" and entries with keys prefixed "%u." for the same index.
> > 
> > This patch adds a test for this case.
> > 
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> > This is a followup to my "Extract non-QDicts in qdict_array_split()" series.
> > 
> 
> > +    /*
> > +     * Test the split of
> > +     *
> > +     * {
> > +     *     "0": 42,
> > +     *     "1": 23,
> > +     *     "1.x": 84
> > +     * }
> 
> For good measure, I might have included a "2":..., which also does not
> get split out (proving that we didn't just skip over 1 and go on to 2,
> but actually stopped).  But at this point, I think you've covered the
> code, so I won't insist.
> 
> Thanks for the extra test:
> Reviewed-by: Eric Blake <address@hidden>

Thanks, applied to the block branch.

Kevin

Attachment: pgpl3dx0axgoQ.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]