[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_close(). |
Date: |
Fri, 21 Feb 2014 14:57:21 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 02:21 PM, Benoît Canet wrote:
> From: Benoît Canet <address@hidden>
>
> Example of command line:
>
> -drive if=virtio,driver=quorum,\
> children.0.file.filename=1.raw,\
> children.0.node-name=1.raw,\
> children.0.driver=raw,\
> children.1.file.filename=2.raw,\
> children.1.node-name=2.raw,\
> children.1.driver=raw,\
> children.2.file.filename=3.raw,\
> children.2.node-name=3.raw,\
> children.2.driver=raw,\
> vote-threshold=2
>
> +++ b/qapi-schema.json
> @@ -4432,6 +4432,24 @@
> 'raw': 'BlockdevRef' } }
>
> ##
> +# @BlockdevOptionsQuorum
> +#
> +# Driver specific block device options for Quorum
> +#
> +# @blkverify: #optional true if the driver must print content mismatch
> +#
I might have mentioned it defaults to false.
> +# @children: the children block device to use
s/device/devices/
> +#
> +# @vote_threshold: the vote limit under which a read will fail
s/_/-/ to match the schema below
> +#
> +# Since: 2.0
> +##
> +{ 'type': 'BlockdevOptionsQuorum',
> + 'data': { '*blkverify': 'bool',
> + 'children': [ 'BlockdevRef' ],
> + 'vote-threshold': 'int' } }
As this series is already queued, we may need a followup patch to fix
these nits.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V19 00/12] Quorum block filter, Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 02/12] quorum: Create BDRVQuorumState and BlkDriver and do init., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 09/12] quorum: Add quorum_co_flush()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 12/12] quorum: Add unit test., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_close().,
Eric Blake <=
- [Qemu-devel] [PATCH V19 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 08/12] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 03/12] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 07/12] quorum: Add quorum_getlength()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Benoît Canet, 2014/02/21