Re: [Qemu-devel] [PATCHv3 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU

[Mark Cave-Ayland]

On 19/02/14 21:35, Mark Cave-Ayland wrote:

> Thanks a lot!
>
> > There's some lines we could extract from the realizefn into an
> > instance_init, but can be done as follow-up when needed.
>
> Okay great. I guess that it's always possible to move something from
> realizefn into instance_init, but not the other way around.
>
> > Two small questions, are vram_size and prom_addr for compatibility? New
> > convention for QOM properties would be dashes.
>
> They are only named that way because that's the way they were in tcx.c.
> Do you want me to adjust and resend?

Hi Andreas,

Due to a lack of response, I've renamed the prom_addr and vram_size 
properties to prom-addr and vram-size as requested and pushed the result 
to my qemu-sparc branch. Hope this is okay in order to get the basic 
patch applied before freeze (I guess it's up to Peter whether a tidy-up 
patch for TCX could be applied after this point or not).


ATB,

Mark.