Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups

[Gerd Hoffmann]

On Mo, 2014-02-24 at 13:32 +0100, Andreas Färber wrote:
> Am 24.02.2014 13:22, schrieb Gerd Hoffmann:
> > Add HDA_AUDIO type and macro, drop DO_UPCAST().
> > 
> > Had to add a abstract hda audio class as parent
> > for all hda-* variants to make that fly.  Killed
> > some init code duplication while being at it.
> > 
> > Cc: Andreas Färber <address@hidden>
> > Signed-off-by: Gerd Hoffmann <address@hidden>
> > ---
> >  hw/audio/hda-codec.c | 60 
> > ++++++++++++++++++++++++++++------------------------
> >  1 file changed, 32 insertions(+), 28 deletions(-)
> 
> Looks good, including introduction of a base type, thanks for cleaning
> this up. These devices are not used by default, right? 

Correct.  Same applied to all other (pc) sound devices, we have no sound
card added by default.

> or would you rather have me prepare
> something?

That would be great.

thanks,
  Gerd