Re: [Qemu-devel] [PATCH] Support NBD client under win32/MinGW

[Or Goshen]

I never used/tested sheepdog under windows with my patch, so I wouldnt know if it doesnt have any additional bugs under windows.

BTW, this patch is on behalf of Intel Corp

On Mon, Feb 24, 2014 at 11:20 AM, Paolo Bonzini <address@hidden> wrote:

Il 24/02/2014 10:13, Or Goshen ha scritto:

+               /* Create event */
+               HANDLE event = WSACreateEvent();
+               long lNetworkEvents = 0;
+
+               if (node->io_read)
+                       lNetworkEvents |= FD_READ;
+               if (node->io_write)
+                       lNetworkEvents |= FD_WRITE;
+
+               WSAEventSelect(node->pfd.fd, event, lNetworkEvents);
+               node->e = (EventNotifier *)event;

As mentioned on IRC, I'd like you to try using the EventNotifier of the AioContext.  You shouldn't need any of these casts.

 ifeq ($(CONFIG_POSIX),y)
-block-obj-y += nbd.o nbd-client.o sheepdog.o
+block-obj-y += nbd-client.o sheepdog.o

nbd-client.c must be compiled on Windows, too.

In fact I think you can just drop the ifeq/endif directives.

 block-obj-$(CONFIG_LIBISCSI) += iscsi.o
 block-obj-$(CONFIG_CURL) += curl.o
 block-obj-$(CONFIG_RBD) += rbd.o

Also, the patch has wrong indentation.  We use 4 space indentation, and never use tabs.

Paolo

--

   Or Goshen
   CTO
   Cerbercomm
   Mob: 972-50-9182418