Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers

[Andreas Färber]

Am 24.02.2014 17:02, schrieb Peter Maydell:
> On 24 February 2014 15:55, Andreas Färber <address@hidden> wrote:
>> Jan/Peter, is there any other outstanding work on musicpal that I should
>> be aware of? If not, I'd like to base the long-planned file splitup on
>> Peter's next pull. Hopefully we can still get that done for 2.0.
> 
> I have a trivial patch on list for it:
> http://patchwork.ozlabs.org/patch/322857/
> 
> which I'm probably not going to put into my next pull unless
> somebody reviews those patches since they've not been on
> list very long. Other than that I'm not aware of anything.

Maybe Jan as author can review it? :)

> (I can trivially rebase that on top of a file split, obviously.)
> 
> I assume you just mean splitting the devices currently in
> hw/arm/musicpal.c out into their own files?

Yes, in particular I had noticed that the NIC (which your linked patch
indeed seems to be touching) was missing in hw/net/, we had previously
talked about doing this. Now that we have qom-test for musicpal and the
Soft Freeze coming up might be a good time to finally do this.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg