Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

[Stefan Weil]

Am 24.02.2014 11:26, schrieb Paolo Bonzini:
> Il 23/02/2014 18:02, Stefan Weil ha scritto:
>> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
>> index 8a303f3..3a0bf13 100644
>> --- a/qga/channel-win32.c
>> +++ b/qga/channel-win32.c
>> @@ -2,7 +2,7 @@
>>  #include <stdio.h>
>>  #include <stdbool.h>
>>  #include <glib.h>
>> -#include <windows.h>
>> +#include "sysemu/os-winapi.h"
>>  #include <errno.h>
>>  #include <io.h>
>>  #include "qga/guest-agent-core.h"
> 
> qga/ is not supposed to include include/sysemu (which is just for
> qemu-system-*).  I guess you can call the new file include/qemu/winapi.h
> 
> Paolo

Ah, thanks for explaining. I'll use the suggested name in an updated
series. But you are aware that qga/ already includes sysemu/os-posix.h
and sysemu/os-win32.h indirectly? Should those two files also be in
include/qemu?

Stefan