[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h |
Date: |
Tue, 25 Feb 2014 18:46:32 +1000 |
Ping!
On Thu, Feb 13, 2014 at 9:21 AM, Peter Crosthwaite
<address@hidden> wrote:
> Hi Edgar,
>
> This file is written for a very old qdev style of machine description.
> Remove by inlining all usages of its functions (which is consistent with
> the modern preference that qdev_initery should be inline and not in
> cross-board helper functions).
>
> To avoid movement of magic numbers, Define macros for IRQ and memory
> maps as appropriate. This cleanup comes first, followed by the
> piecewise removal of xilinx.h.
>
> Regards,
> Peter
>
>
> Peter Crosthwaite (8):
> microblaze/s3adsp_1800: Define macros for irq map
> ppc/virtex_ml507: Define macros for irq/memory maps
> microblaze/ml605: Define macros for irq/memory maps
> xilinx: Inline usages of xilinx_intc_create()
> xilinx: Inline usages of xilinx_timer_create()
> xilinx: Inline usage of xilinx_ethlite_create()
> xilinx: Inline usages of xilinx_axi*_init()
> xilinx: Delete hw/include/xilinx.h
>
> hw/microblaze/petalogix_ml605_mmu.c | 55 ++++++++++++++-----
> hw/microblaze/petalogix_s3adsp1800_mmu.c | 35 ++++++++++---
> hw/ppc/virtex_ml507.c | 29 +++++++---
> include/hw/xilinx.h | 90
> --------------------------------
> 4 files changed, 95 insertions(+), 114 deletions(-)
> delete mode 100644 include/hw/xilinx.h
>
> --
> 1.8.5.4
>
- [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h, Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 1/8] microblaze/s3adsp_1800: Define macros for irq map, Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 2/8] ppc/virtex_ml507: Define macros for irq/memory maps, Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 4/8] xilinx: Inline usages of xilinx_intc_create(), Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 5/8] xilinx: Inline usages of xilinx_timer_create(), Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 6/8] xilinx: Inline usage of xilinx_ethlite_create(), Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 7/8] xilinx: Inline usages of xilinx_axi*_init(), Peter Crosthwaite, 2014/02/12
- [Qemu-devel] [PATCH microblaze/ppc v2 8/8] xilinx: Delete hw/include/xilinx.h, Peter Crosthwaite, 2014/02/12
- Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h,
Peter Crosthwaite <=