[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Drop legacy device lists? (was: [PATCH] e1000: add the abil
From: |
Stefan Weil |
Subject: |
[Qemu-devel] Drop legacy device lists? (was: [PATCH] e1000: add the ability to select among several specific types of e1000 ...) |
Date: |
Tue, 25 Feb 2014 19:26:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 25.02.2014 09:01, schrieb Andreas Färber:
> Hi,
>
> Am 24.02.2014 20:08, schrieb Romain Dolbeau:
[...]
>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
>> index 4e0701d..07c8cdd 100644
>> --- a/hw/pci/pci.c
>> +++ b/hw/pci/pci.c
>> @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = {
>> "i82559er",
>> "rtl8139",
>> "e1000",
>> + "82540EM",
>> + "82544GC",
>> + "82545EM",
>> "pcnet",
>> "virtio",
>> NULL
>> @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] = {
>> "i82559er",
>> "rtl8139",
>> "e1000",
>> + "82540EM",
>> + "82544GC",
>> + "82545EM",
>> "pcnet",
>> "virtio-net-pci",
>> NULL
> I would hope that adding to these two legacy lists is not necessary for
> new types. They should be created using -device, not -net nic,model=.
>
> Regards,
> Andreas
What about removing those lists for QEMU 2.0? We should use the version
update to get rid of some legacy interfaces.
Stefan