Re: [Qemu-devel] [PATCH microblaze/ppc v3 0/8] Remove include/hw/xilinx.h

[Edgar E. Iglesias]

On Tue, Feb 25, 2014 at 04:37:43PM -0800, Peter Crosthwaite wrote:
> Hi Edgar,
> 
> This file is written for a very old qdev style of machine description.
> Remove by inlining all usages of its functions (which is consistent with
> the modern preference that qdev_initery should be inline and not in
> cross-board helper functions).
> 
> To avoid movement of magic numbers, Define macros for IRQ and memory
> maps as appropriate. This cleanup comes first, followed by the
> piecewise removal of xilinx.h.


Applied, thanks Peter.

Cheers,
Edgar



> 
> Regards,
> Peter
> 
> 
> Peter Crosthwaite (8):
>   microblaze/s3adsp_1800: Define macros for irq map
>   ppc/virtex_ml507: Define macros for irq/memory maps
>   microblaze/ml605: Define macros for irq/memory maps
>   xilinx: Inline usages of xilinx_intc_create()
>   xilinx: Inline usages of xilinx_timer_create()
>   xilinx: Inline usage of xilinx_ethlite_create()
>   xilinx: Inline usages of xilinx_axi*_init()
>   xilinx: Delete hw/include/xilinx.h
> 
>  hw/microblaze/petalogix_ml605_mmu.c      | 55 ++++++++++++++-----
>  hw/microblaze/petalogix_s3adsp1800_mmu.c | 35 ++++++++++---
>  hw/ppc/virtex_ml507.c                    | 29 +++++++---
>  include/hw/xilinx.h                      | 90 
> --------------------------------
>  4 files changed, 95 insertions(+), 114 deletions(-)
>  delete mode 100644 include/hw/xilinx.h
> 
> -- 
> 1.9.0.1.g4196000
>