Re: [Qemu-devel] [PATCH RESEND] CODING_STYLE: Section about mixed declarations

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> We had an unwritten rule about declarations having to be at beginning of
> blocks. Make it a written rule.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> Reviewed-by: Stefan Weil <address@hidden>
> ---
> Changes v2:
>  * s/be at beginning/be at the beginning/
> ---
>  CODING_STYLE | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index dcbce28..efa5cc3 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -84,3 +84,10 @@ and clarity it comes on a line by itself:
>  Rationale: a consistent (except for functions...) bracing style reduces
>  ambiguity and avoids needless churn when lines are added or removed.
>  Furthermore, it is the QEMU coding style.
> +
> +5. Declarations
> +
> +Mixed declarations (interleaving statements and declarations within blocks) 
> are
> +not allowed; declarations should be at the beginning of blocks.  In other 
> words,
> +the code should not generate warnings if using GCC's
> +-Wdeclaration-after-statement option.

Long lines.  We'll live.

I'd like to see either arguments or a commit.  For good measure:

Reviewed-by: Markus Armbruster <address@hidden>