[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] qapi: Add tests for the "include" direct
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] qapi: Add tests for the "include" directive |
Date: |
Thu, 27 Feb 2014 14:16:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/11/2014 06:00 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> +++ b/tests/Makefile
> @@ -124,7 +124,8 @@ check-qapi-schema-y := $(addprefix tests/qapi-schema/, \
> missing-comma-object.json non-objects.json \
> qapi-schema-test.json quoted-structural-chars.json \
> trailing-comma-list.json trailing-comma-object.json \
> - unclosed-list.json unclosed-object.json unclosed-string.json)
> + unclosed-list.json unclosed-object.json unclosed-string.json\
The other lines have a space before \, but that's cosmetic. This will
conflict with Wenchao's series to add enum discriminators of unions, but
that should be an obvious conflict resolution for whichever series goes
in second.
> +++ b/tests/qapi-schema/include-cycle.err
> @@ -0,0 +1 @@
> +include-cycle.json:1:1: Inifite inclusion loop: include-cycle.json ->
> include-cycle.json
Once the typo in 2/3 is fixed, this needs fixing too.
You tested a single-cycle file, but it might also be worth adding a
circular chain (A includes B, B includes C, C includes A) to prove it
also triggers the cycle-detection logic.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature