[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discr
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discriminator |
|
Date: |
Thu, 27 Feb 2014 15:05:05 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/27/2014 04:09 AM, Wenchao Xia wrote:
> From: Wenchao Xia <address@hidden>
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Wenchao Xia <address@hidden>
Double S-o-B. The commit message is a bit sparse; the one-line summary
mentions what, but for a change like this where you are taking away
functionality, it's also good to mention WHY (hint: enum-based
discriminators provide better type-safety and ensure that future qapi
additions do not forget to adjust dependent unions).
> ---
> docs/qapi-code-gen.txt | 5 +----
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union, (continued)
- [Qemu-devel] [PATCH V8 05/10] qapi script: code move for generate_enum_name(), Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 06/10] qapi script: use same function to generate enum string, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 07/10] qapi script: support enum type as discriminator in union, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use enum discriminator, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discriminator, Wenchao Xia, 2014/02/27
- Re: [Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discriminator,
Eric Blake <=
- [Qemu-devel] [PATCH V8 10/10] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2014/02/27
- Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2014/02/28