|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing |
Date: | Fri, 28 Feb 2014 11:45:06 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 28/02/2014 06:27, Stefan Weil ha scritto:
>> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) >> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)Using SUBDIR_RULES here instead of SOFTMMU_SUBDIR_RULES (as in my patch) includes more dependencies: $(block-obj-y) will also be built for the user emulation code (i386-linux-user, ...) which does not need it. As far as I see, SOFTMMU_SUBDIR_RULES is sufficient.
True, it's just ugly to have all the dependencies in different parts of the Makefile.
If you fix it, can you move this line close to the existing $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak We have too many knobs. :( Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |