[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] XBZRLE: rebuild the cache_is_cached functio
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] XBZRLE: rebuild the cache_is_cached function |
Date: |
Fri, 28 Feb 2014 06:13:46 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/27/2014 09:10 PM, Gonglei (Arei) wrote:
> Rebuild the cache_is_cached function.
>
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> page_cache.c | 33 +++++++++++++++------------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/page_cache.c b/page_cache.c
> index fa58ab2..34ec933 100644
> --- a/page_cache.c
> +++ b/page_cache.c
> @@ -121,24 +121,6 @@ static size_t cache_get_cache_pos(const PageCache *cache,
> return pos;
> }
>
> -bool cache_is_cached(const PageCache *cache, uint64_t addr,
> - uint64_t current_age)
Indentation was off pre-patch...
>
> +bool cache_is_cached(const PageCache *cache, uint64_t addr,
> + uint64_t current_age)
...but you should take the opportunity to fix it here.
bool cache_is_cached(const PageCache *cache, uint64_t addr,
uint64_t current_age)
> + if (it->it_addr == addr) {
> + /* updata the it_age when the cache hit */
s/updata/update/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature