[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error hand
|
From: |
Marcelo Tosatti |
|
Subject: |
Re: [Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error handling |
|
Date: |
Thu, 27 Feb 2014 22:05:57 -0300 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 27, 2014 at 07:30:26PM +0100, Paolo Bonzini wrote:
> Il 04/02/2014 19:41, Marcelo Tosatti ha scritto:
> >
> >-mem-prealloc asks to preallocate memory residing on -mem-path path.
> >
> >Currently QEMU exits in case:
> >
> >- Memory file has been created but allocation via explicit write
> >fails.
> >
> >And it fallbacks to malloc in case:
> >- Querying huge page size fails.
> >- Lack of sync MMU support.
> >- Open fails.
> >- mmap fails.
> >
> >Have the same behaviour for all cases: fail in case -mem-path and
> >-mem-prealloc are specified for regions where the requested size is
> >suitable for hugepages.
> >
> >Signed-off-by: Marcelo Tosatti <address@hidden>
>
> Once we introduce memdev, I believe -mem-path should always exit,
> and never fall back to malloc/MAP_ANON.
Agree.