[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements |
|
Date: |
Fri, 28 Feb 2014 17:30:11 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 26.02.2014 18:18, schrieb Jason J. Herne:
> From: "Jason J. Herne" <address@hidden>
>
> Modify s390_cpu_addr2state to allow fetching state information for cpu
> addresses
> above smp_cpus. Hotplug requires this capability.
>
> Also add s390_cpu_set_state function to allow modification of ipi_state
> entries
> during hotplug.
>
> Signed-off-by: Jason J. Herne <address@hidden>
This patch is *still* present despite your previous response that you
incorporated my review comments. You are adding a custom s390x API here
rather than reusing the generic QOM API as requested. I don't even read
further in such cases - like I pointed out, a pure resend is not helping
address review feedback!
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg