[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common |
|
Date: |
Fri, 28 Feb 2014 09:19:36 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/26/2014 01:53 PM, Peter Maydell wrote:
> In QEMU we don't make any use at all of the common symbol
> functionality, so we can avoid this problem entirely simply
> by compiling with -fno-common. Enable this option for all
> builds, not just MacOSX, so that if we ever inadvertently
> introduce multiple definitions of some variable that will
> be immediately spotted as a build error rather than only
> breaking the MacOSX build.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
r~