[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in q
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str() |
Date: |
Sat, 1 Mar 2014 08:40:38 +0100 |
Argument can't be null. No other Visitor method type_str() checks for
null.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qapi/qapi-dealloc-visitor.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
index dc53545..d0ea118 100644
--- a/qapi/qapi-dealloc-visitor.c
+++ b/qapi/qapi-dealloc-visitor.c
@@ -131,9 +131,7 @@ static void qapi_dealloc_end_list(Visitor *v, Error **errp)
static void qapi_dealloc_type_str(Visitor *v, char **obj, const char *name,
Error **errp)
{
- if (obj) {
- g_free(*obj);
- }
+ g_free(*obj);
}
static void qapi_dealloc_type_int(Visitor *v, int64_t *obj, const char *name,
--
1.8.1.4
- [Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types, (continued)
- [Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 02/13] tests/qapi-schema: Cover optional command arguments, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 01/13] tests/qapi-schema: Actually check successful QMP command response, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 06/13] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct(), Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 05/13] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 08/13] qapi: Fix licensing of scripts, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 03/13] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 10/13] qapi: Drop unused code in qapi-commands.py, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 07/13] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/03/01
- Re: [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code, Luiz Capitulino, 2014/03/03