[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in genera
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors |
Date: |
Sat, 01 Mar 2014 06:38:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/01/2014 12:40 AM, Markus Armbruster wrote:
> Visitors get passed a pointer to the visited object. The generated
> visitors try to cope with this pointer being null in some places, for
> instance like this:
>
> visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err);
>
> visit_start_optional() passes its second argument to Visitor method
> start_optional. Three out of three methods dereference it
> unconditionally.
>
> I fail to see how hits pointer could legitimately be null.
s/hits/this/
>
> All this useless null checking is highly redundant, which Coverity
> duly reports. About 200 times.
>
> Remove the useless null checks.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Still stands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 02/13] tests/qapi-schema: Cover optional command arguments, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 01/13] tests/qapi-schema: Actually check successful QMP command response, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 06/13] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct(), Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 05/13] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/03/01
- Re: [Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors,
Eric Blake <=
- [Qemu-devel] [PATCH v3 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 08/13] qapi: Fix licensing of scripts, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str(), Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 03/13] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 10/13] qapi: Drop unused code in qapi-commands.py, Markus Armbruster, 2014/03/01
- [Qemu-devel] [PATCH v3 07/13] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/03/01
- Re: [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code, Luiz Capitulino, 2014/03/03