Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

[Paolo Bonzini]

Il 02/03/2014 01:17, Gabriel L. Somlo ha scritto:
> Although, on KVM, it's simply hardcoded to 0x14 rather than exposing to
> the guest whatever the host CPU's apic version happens to be, or
> trying to match it to the CPU model:
>
>
> address@hidden kvm]$ grep -i version arch/x86/kvm/lapic.c
> ...
> /* 14 is the version for Xeon and Pentium 8.4.8*/
> #define APIC_VERSION                    (0x14UL | ((APIC_LVT_NUM - 1) << 16))
> ...
>
>
> I'd honestly prefer to stick to 0x14 (because it's simple :) )

I'd also prefer that, because I like having the same for KVM and TCG, 
but I'm not sure it'd fly with others. :)

> but if you're sure that's a bad idea, how about the struct x86_def_t
> rather than qdev ?
>
> So far, only OS X seems to even care at all about the version...

Andreas, Michael, what do you think?

Paolo