Re: [Qemu-devel] [PATCH v21 02/25] qapi: output def_value_str when query command line options

[Chunyan Liu]

2014-03-04 8:02 GMT+08:00 Eric Blake <address@hidden>:

On 02/21/2014 03:35 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
>  qapi-schema.json   |    8 ++++++--
>  qmp-commands.hx    |    2 ++
>  util/qemu-config.c |    4 ++++
>  3 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 473c096..83e5870 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4010,12 +4010,16 @@
>  #
>  # @help: #optional human readable text string, not suitable for parsing.
>  #
> -# Since 1.5
> +# @default: #optional string representation of the default used
> +#           if the option is omitted.
> +#
> +# Since 2.0

Not quite right.  This needs to be:

# @help: #optional human readable text string, not suitable for parsing.
#

# @default: #optional string representation of the default used

#           if the option is omitted (since 2.0).
#
# Since 1.5
 

Thanks, will update.
 

--
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org