Re: [Qemu-devel] [RFC PATCH v0] ppc: Force CPU threads count to be a power of 2.

[Stewart Smith]

Bharata B Rao <address@hidden> writes:
> @@ -7987,6 +7989,12 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error 
> **errp)
>                     max_smt, kvm_enabled() ? "KVM" : "TCG");
>          return;
>      }
> +    threads_shift = log2(smp_threads);
> +    if (smp_threads != (1 << threads_shift)) {
> +        error_setg(errp, "Cannot support %d threads on PPC with %s",
> +                   smp_threads, kvm_enabled() ? "KVM" : "TCG");
> +        return;
> +    }
>  #endif
>
>      if (kvm_enabled()) {

I'd suggest adding "(must be power of 2)" to the error message
somewhere.

with that,
Acked-by: Stewart Smith <address@hidden>