[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of "exec-all.h" |
|
Date: |
Tue, 4 Mar 2014 11:16:17 +0000 |
On 4 March 2014 11:11, Peter Maydell <address@hidden> wrote:
> On 4 March 2014 02:47, Xuebing Wang <address@hidden> wrote:
>> include/exec/exec-all.h should ONLY be included in target-xxx/*
>
> Why?
>
> This header file defines a number of functions and types
> that are used outside target-xxx/. At the moment we implicitly
> rely on cpu.h pulling them in.
My question still stands, but this bit is wrong:
> Maybe it would be nice to split
> out the things that only the target frontends care about from
> APIs used by other parts of QEMU, but that's not what this patch
> is doing.
...because that is what patch 8 does. Sorry, read those out of order.
thanks
-- PMM
- [Qemu-devel] [Discussion 07/10] memory: remove file include/exec/address-spaces.h, (continued)
- [Qemu-devel] [Discussion 07/10] memory: remove file include/exec/address-spaces.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 06/10] memory: move contents in include/exec/address-spaces.h => memory.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 10/10] translate: remove file translate-all.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 08/10] exec: move TranslationBlock API from exec-all.h => translate.h, Xuebing Wang, 2014/03/03
- [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of "exec-all.h", Xuebing Wang, 2014/03/03
- Re: [Qemu-devel] [Discussion 00/10] about API hierarchy, Andreas Färber, 2014/03/03