Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include "cpu.h"' from include/qemu-common.h

[Paolo Bonzini]

Il 04/03/2014 13:19, Xuebing wang ha scritto:
> > Like Andreas I don't like this particularly.  You can add
> > migration/vmstate.h to qom/cpu.h instead.
>
> In my humble opinion, qom/cpu is part of virtual machine along with
> other hw peripherals, thus I'd prefer vmstate to depend on qom/cpu.
>
> From object oriented design perspective, qom/cpu is one-level lower than
> the modeling of virtual machine, do you agree?

vmstate is just the name of the infrastructure that takes a description 
of a struct's fields and serializes it onto a QEMUFile.  If you look at 
include/migration, there's nothing that is specific to virtual machines 
except perhaps the declaration of two functions vmstate_register_ram and 
vmstate_unregister_ram.

Paolo