[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2.1 10/28] qmp: allow object-add completion handler
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 2.1 10/28] qmp: allow object-add completion handler to get canonical path |
Date: |
Tue, 4 Mar 2014 15:00:38 +0100 |
From: Igor Mammedov <address@hidden>
Add object to /objects before calling user_creatable_complete()
handler, so that object might be able to call
object_get_canonical_path() in its completion handler.
Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
qmp.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qmp.c b/qmp.c
index d0d98e7..2ff943d 100644
--- a/qmp.c
+++ b/qmp.c
@@ -561,13 +561,15 @@ void object_add(const char *type, const char *id, const
QDict *qdict,
goto out;
}
+ object_property_add_child(container_get(object_get_root(), "/objects"),
+ id, obj, &local_err);
+
user_creatable_complete(obj, &local_err);
if (local_err) {
+ object_property_del(container_get(object_get_root(), "/objects"),
+ id, &error_abort);
goto out;
}
-
- object_property_add_child(container_get(object_get_root(), "/objects"),
- id, obj, &local_err);
out:
if (local_err) {
error_propagate(errp, local_err);
--
1.8.5.3
- Re: [Qemu-devel] [PATCH 2.1 07/28] qemu-option: introduce qemu_find_opts_singleton, (continued)
- [Qemu-devel] [PATCH 2.1 08/28] vl: convert -m to QemuOpts, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 09/28] vl: redo -object parsing, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 10/28] qmp: allow object-add completion handler to get canonical path,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2.1 11/28] qmp: improve error reporting for -object and object-add, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 12/28] pc: pass QEMUMachineInitArgs to pc_memory_init, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 13/28] numa: introduce memory_region_allocate_system_memory, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 14/28] add memdev backend infrastructure, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 15/28] numa: add -numa node, memdev= option, Paolo Bonzini, 2014/03/04