[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2.1 15/28] numa: add -numa node, memdev= option
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2.1 15/28] numa: add -numa node, memdev= option |
Date: |
Tue, 04 Mar 2014 10:52:59 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/04/2014 07:00 AM, Paolo Bonzini wrote:
> This option provides the infrastructure for binding guest NUMA nodes
> to host NUMA nodes. For example:
>
> -object memory-ram,size=1024M,policy=membind,host-nodes=0,id=ram-node0 \
> -numa node,nodeid=0,cpus=0,memdev=ram-node0 \
> -object memory-ram,size=1024M,policy=interleave,host-nodes=1-3,id=ram-node1 \
> -numa node,nodeid=1,cpus=1,memdev=ram-node1
>
> The option replaces "-numa node,mem=".
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4543,10 +4543,16 @@
> # @mem: #optional memory size of this node (equally divide total memory among
> # nodes if omitted)
> #
> +# @memdev: #optional memory backend object. If specified for one node,
> +# it must be specified for all nodes.
> +#
> +# @mem: #optional memory size of this node; mutually exclusive with @memdev.
No need to list @mem a second time, just add the mutual exclusion
comment to the first listing.
>
> DEF("numa", HAS_ARG, QEMU_OPTION_numa,
> - "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
> + "-numa node[,mem=size][,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n",
> QEMU_ARCH_ALL)
Since this is mutually exclusive, would it be better to split into two
lines, as in:
"-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n"
"-numa node,memdev=id[,cpus=cpu[-cpu]][,nodeid=node]\n"
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 2.1 11/28] qmp: improve error reporting for -object and object-add, (continued)
- [Qemu-devel] [PATCH 2.1 11/28] qmp: improve error reporting for -object and object-add, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 12/28] pc: pass QEMUMachineInitArgs to pc_memory_init, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 13/28] numa: introduce memory_region_allocate_system_memory, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 14/28] add memdev backend infrastructure, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 15/28] numa: add -numa node, memdev= option, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 16/28] memory: reorganize file-based allocation, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 17/28] memory: move mem_path handling to memory_region_allocate_system_memory, Paolo Bonzini, 2014/03/04