[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join() |
|
Date: |
Wed, 05 Mar 2014 09:52:37 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/03/2014 08:28 AM, Max Reitz wrote:
> This function joins two QDicts by absorbing one into the other.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> include/qapi/qmp/qdict.h | 3 +++
> qobject/qdict.c | 32 ++++++++++++++++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
However, I think you should expand the testsuite to cover this addition
(can be a followup)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 04/10] block/json: Add functions for writing zeroes etc., Max Reitz, 2014/03/03