[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol |
Date: |
Wed, 05 Mar 2014 10:27:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/03/2014 08:28 AM, Max Reitz wrote:
> Add a test for the JSON protocol driver.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/084 | 114
> +++++++++++++++++++++++++++++++++++++++++++++
> +
> +# Taken from test 072
The comment is okay, but...
> +echo
> +echo "=== Testing nested image formats (072) ==="
...maybe this echo should be updated to mention test 084.
> +$QEMU_IO -c 'read -P 42 0 512' -c 'read -P 23 512 512' \
> + -c 'read -P 66 1024 512' "json:{
> + \"driver\": \"$IMGFMT\",
> + \"file\": {
> + \"driver\": \"$IMGFMT\",
> + \"file\": {
> + \"filename\": \"$TEST_IMG\"
Are we guaranteed that $TEST_IMG will not contain any " which would
render this invalid JSON?
> +
> +# Taken from test 071
> +echo
> +echo "=== Testing blkdebug (071) ==="
Hmm - now you're mentioning yet another test id different than 084. So
I guess this was just a hint that you are reproducing earlier tests but
now with the context of a json: protocol. Still, doesn't "Testing
blkdebug" convey sufficient information, without also needing "(071)"
for confusion? At any rate, I don't think this affects the coverage of
the test.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status(), (continued)
[Qemu-devel] [PATCH 07/10] block/json: Add bdrv_get_specific_info(), Max Reitz, 2014/03/03
[Qemu-devel] [PATCH 09/10] block/qapi: Ignore filters on top for format name, Max Reitz, 2014/03/03
[Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol, Max Reitz, 2014/03/03
- Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol,
Eric Blake <=
[Qemu-devel] [PATCH 08/10] block/raw_bsd: Add bdrv_get_specific_info(), Max Reitz, 2014/03/03
[Qemu-devel] [PATCH 03/10] block/json: Add functions for cache control, Max Reitz, 2014/03/03
[Qemu-devel] [PATCH 06/10] block/json: Add ioctl etc., Max Reitz, 2014/03/03
Re: [Qemu-devel] [PATCH 00/10] block/json: Add JSON protocol driver, Eric Blake, 2014/03/05