Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field.

[Kevin Wolf]

Am 05.03.2014 um 23:48 hat Benoît Canet geschrieben:
> Moving only the node_name one field could lead to some inconsitencies where a
> node_name was defined on a bs which was not registered in the graph node list.
> 
> bdrv_swap between a named node bs and a non named node bs would lead to this.
> 
> bdrv_make_anon would then crash because it would try to remove the bs from the
> graph node list while it is not in it.
> 
> This patch remove named node bses from the graph node list before doing the 
> swap
> then insert them back.
> 
> Signed-off-by: Benoit Canet <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>

By the way, can you please just use the PATCH keyword in the subject
line like everyone else? Some people are relying on this to filter their
mail. If you like to express your intention to get it merged in time for
2.0, the traditional format is [PATCH for-2.0].

Kevin