[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined N
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H |
Date: |
Thu, 06 Mar 2014 16:16:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Hi,
Am 06.03.2014 11:27, schrieb Xuebing Wang:
> I am not sure if there is value for this patchset.
>
> After the first pach:
> Size of x86_64-softmmu/qemu-system-x86_64 is unchanged.
> Size of sh4-softmmu/qemu-system-sh4 increases by about 2.8KB.
>
> Xuebing Wang (7):
> kvm: remove the hack "#if defined CONFIG_KVM || !defined NEED_CPU_H"
> kvm-i386: fix build for x86_64-linux-user after applying previous
> patch
> kvm-i386: remove target-i386/kvm-stub.c
> kvm: fix build for target sh4-softmmu
> kvm-ppc: fix build for ppc64-softmmu
> kvm-ppc: remove target-ppc/kvm-stub.c
> kvm-i386: fix build for "x86_64-softmmu --disable-kvm"
Generally, you can't just break things and then later fix them. You need
to keep things building in each commit you make, for bisectability.
Also may I propose that we continue these cleanup discussions once we're
in Hard Freeze next week? There's still actual features and bug fixes to
be reviewed until then.
http://wiki.qemu.org/Planning/2.0
Further I notice that Alex and the qemu-ppc list were not CC'ed on
patches 5-6. You may find the following useful to automate this:
$ git config sendemail.cccmd \
"scripts/get_maintainer.pl --nogit-fallback"
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H, Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 3/7] kvm-i386: remove target-i386/kvm-stub.c, Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 1/7] kvm: remove the hack "#if defined CONFIG_KVM || !defined NEED_CPU_H", Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 2/7] kvm-i386: fix build for x86_64-linux-user after applying previous patch, Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 6/7] kvm-ppc: remove target-ppc/kvm-stub.c, Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 4/7] kvm: fix build for target sh4-softmmu, Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 5/7] kvm-ppc: fix build for ppc64-softmmu, Xuebing Wang, 2014/03/06
- [Qemu-devel] [PATCH 7/7] kvm-i386: fix build for "x86_64-softmmu --disable-kvm", Xuebing Wang, 2014/03/06
- Re: [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H, Paolo Bonzini, 2014/03/06
- Re: [Qemu-devel] [PATCH 0/7] remove #if defined CONFIG_KVM || !defined NEED_CPU_H,
Andreas Färber <=