Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema

[Eric Blake]

On 01/06/2014 04:18 PM, Luiz Capitulino wrote:
> On Fri,  3 Jan 2014 07:10:29 +0800
> Wenchao Xia <address@hidden> wrote:
> 
>> This series add support for tag/keyword 'event' in qapi-schema.
>> A new file was created to store some helper functions in patch 2, patch 4 is
>> the test case, patch 5 is a convert example.
>>
>> The implemention is done by generate API and a batch of parameters for each
>> event define, it doesn't generate a struture and visit function in the
>> background for every event, so it doesn't support nested structure in the
>> define to avoid trouble. A callback layer is added to control the behavior.
>> More detail can be found in patch 3's message and incode comments.
> 
> The general approach seems good to me. Would be nice to get another
> reviewer though, maybe Eric and/or Michael.

Just now looking at this thread.  Is this still something that we want
in 2.0, or at this point are we late enough to delay to 2.1?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature