qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH V2 5/5] qapi event: convert RTC_CHANGE


From: Eric Blake
Subject: Re: [Qemu-devel] [RFC PATCH V2 5/5] qapi event: convert RTC_CHANGE
Date: Thu, 06 Mar 2014 13:24:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 01/02/2014 04:10 PM, Wenchao Xia wrote:
> This is just an example of how to use qapi event API, and it
> bypassed the event throttle queue. A complete convert should
> be first define all events in qapi-schema.json, use qapi
> event types in monitor functions, then change calller one

s/calller/caller/

> by one.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  monitor.c        |   14 ++++++++++++++
>  qapi-schema.json |    3 +++
>  vl.c             |    7 ++-----
>  3 files changed, 19 insertions(+), 5 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -4247,3 +4247,6 @@
>  # Since: 1.7
>  ##
>  { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
> +
> +{ 'event': 'RTC_CHANGE',

You'll need to add documentation before each 'event' (hint - crib the
existing documentation we already have in qmp-events.txt)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]